Skip to content

Rename Number Tag labels to Item Tag for identifier alignment#28

Merged
dadachi merged 1 commit intomainfrom
phase2-prestep-number-tag-rename
Apr 24, 2026
Merged

Rename Number Tag labels to Item Tag for identifier alignment#28
dadachi merged 1 commit intomainfrom
phase2-prestep-number-tag-rename

Conversation

@dadachi
Copy link
Copy Markdown
Contributor

@dadachi dadachi commented Apr 24, 2026

Summary

  • Free-Android port of nativeapptemplate/NativeAppTemplate-Android#37.
  • Aligns UI labels with the ItemTag identifier (Phase 2 pre-step), so future humanize-based string-literal rename logic (Phase 6) can rewrite them consistently.
  • Renames in-scope generic labels only; queue-specific strings (swipe_number_tag_below, server_number_tags_webpage*, reset_number_tags*, onboarding_description*, complete_scan_help, show_tag_info_scan_help) are intentionally kept — they'll be deleted alongside NFC/scan/reset code in Phase 2 Part A.
  • Also renames resource identifier R.string.label_shop_settings_manage_number_tagsR.string.label_shop_settings_manage_item_tags and updates its 3 callers.

Label changes (app/src/main/res/values/strings.xml)

  • Manage Number TagsManage Item Tags
  • Tag NumberName (aligns with ItemTag.name after Phase 1 API refactor)
  • Add a new number tag…Add a new item tag…
  • Tag number is invalid.Item tag name is invalid.
  • Direct literals in ItemTagCreateView/ItemTagEditView supporting text: Tag Number must be a 2-N alphanumeric characters.Name must be a 2-N alphanumeric characters.

Test plan

  • ./gradlew assembleDebug succeeds (verified locally: BUILD SUCCESSFUL)
  • ./gradlew test passes (verified locally: BUILD SUCCESSFUL)
  • Manual UI check: Shop Settings shows Manage Item Tags; ItemTag list title shows Manage Item Tags
  • Manual UI check: ItemTag Create/Edit field header shows Name, supporting text shows Name must be a 2-N alphanumeric characters. and Item tag name is invalid. on invalid input
  • grep -rn "Number Tag" --include="*.kt" --include="*.xml" in source returns only out-of-scope queue/scan/onboarding entries in strings.xml
  • grep -rn "Tag Number" --include="*.kt" --include="*.xml" in source returns nothing

🤖 Generated with Claude Code

- 'Manage Number Tags' -> 'Manage Item Tags'
- 'Tag Number' -> 'Name' (aligns with ItemTag.name after Phase 1 API refactor)
- 'Add a new number tag...' -> 'Add a new item tag...'
- 'Tag number is invalid.' -> 'Item tag name is invalid.'
- Direct literals in ItemTagCreateView/ItemTagEditView supporting text:
  'Tag Number must be a 2-N alphanumeric characters.' -> 'Name must be a 2-N alphanumeric characters.'
- Resource id: R.string.label_shop_settings_manage_number_tags -> label_shop_settings_manage_item_tags

Queue-specific strings (swipe_number_tag_below, server_number_tags_webpage*,
reset_number_tags*, onboarding_description*, complete_scan_help,
show_tag_info_scan_help) are intentionally kept for now; they will be
deleted alongside NFC/scan/reset code in Phase 2 Part A.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dadachi dadachi merged commit e019319 into main Apr 24, 2026
1 check passed
@dadachi dadachi deleted the phase2-prestep-number-tag-rename branch April 24, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant