Rename Number Tag labels to Item Tag for identifier alignment#28
Merged
Rename Number Tag labels to Item Tag for identifier alignment#28
Conversation
- 'Manage Number Tags' -> 'Manage Item Tags' - 'Tag Number' -> 'Name' (aligns with ItemTag.name after Phase 1 API refactor) - 'Add a new number tag...' -> 'Add a new item tag...' - 'Tag number is invalid.' -> 'Item tag name is invalid.' - Direct literals in ItemTagCreateView/ItemTagEditView supporting text: 'Tag Number must be a 2-N alphanumeric characters.' -> 'Name must be a 2-N alphanumeric characters.' - Resource id: R.string.label_shop_settings_manage_number_tags -> label_shop_settings_manage_item_tags Queue-specific strings (swipe_number_tag_below, server_number_tags_webpage*, reset_number_tags*, onboarding_description*, complete_scan_help, show_tag_info_scan_help) are intentionally kept for now; they will be deleted alongside NFC/scan/reset code in Phase 2 Part A. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemTagidentifier (Phase 2 pre-step), so future humanize-based string-literal rename logic (Phase 6) can rewrite them consistently.swipe_number_tag_below,server_number_tags_webpage*,reset_number_tags*,onboarding_description*,complete_scan_help,show_tag_info_scan_help) are intentionally kept — they'll be deleted alongside NFC/scan/reset code in Phase 2 Part A.R.string.label_shop_settings_manage_number_tags→R.string.label_shop_settings_manage_item_tagsand updates its 3 callers.Label changes (
app/src/main/res/values/strings.xml)Manage Number Tags→Manage Item TagsTag Number→Name(aligns withItemTag.nameafter Phase 1 API refactor)Add a new number tag…→Add a new item tag…Tag number is invalid.→Item tag name is invalid.ItemTagCreateView/ItemTagEditViewsupporting text:Tag Number must be a 2-N alphanumeric characters.→Name must be a 2-N alphanumeric characters.Test plan
./gradlew assembleDebugsucceeds (verified locally:BUILD SUCCESSFUL)./gradlew testpasses (verified locally:BUILD SUCCESSFUL)Manage Item Tags; ItemTag list title showsManage Item TagsName, supporting text showsName must be a 2-N alphanumeric characters.andItem tag name is invalid.on invalid inputgrep -rn "Number Tag" --include="*.kt" --include="*.xml"in source returns only out-of-scope queue/scan/onboarding entries instrings.xmlgrep -rn "Tag Number" --include="*.kt" --include="*.xml"in source returns nothing🤖 Generated with Claude Code