Fix description silently dropped by encodeDefaults=false#55
Merged
Conversation
The Retrofit kotlinx Json (NetModule) keeps encodeDefaults=false, so a @serializable request-body property equal to its declared default is omitted from the payload. ItemTagBodyDetail.description = "" (== default) was dropped, so clearing a description on edit was silently ignored by the server's partial update. Drop the default (both call sites already pass description explicitly); update DemoItemTagRepositoryTest to pass description explicitly. Bump versionCode to 11 / versionName to 3.2.6 and update CHANGELOG. Mirrors NativeAppTemplate-Android a78f42e. (The DeviceRegistrationBody fix in that commit does not apply — the Free variant has no device registration.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors NativeAppTemplate-Android a78f42e.
The Retrofit kotlinx
Jsonconfig (NetModule) keepsencodeDefaults = false, so a@Serializablerequest-body property equal to its declared default is omitted from the payload.ItemTagBodyDetail.description = ""(== default) was dropped, so clearing a description on edit was silently ignored by the server's partial update. This drops the default — both production call sites (ItemTagCreateViewModel,ItemTagEditViewModel) already passdescriptionexplicitly, so the empty string is now always sent.Changes
ItemTagBodyDetail: removed thedescriptiondefault (with explanatory comment)DemoItemTagRepositoryTest: passdescription = ""explicitly at both call sitesTesting
./gradlew :app:testDebugUnitTest --tests "...DemoItemTagRepositoryTest"✅🤖 Generated with Claude Code