Skip to content

Add pagination support for item tags list#36

Merged
dadachi merged 2 commits intomainfrom
pagination-item-tags
Apr 3, 2026
Merged

Add pagination support for item tags list#36
dadachi merged 2 commits intomainfrom
pagination-item-tags

Conversation

@dadachi
Copy link
Copy Markdown
Contributor

@dadachi dadachi commented Apr 3, 2026

Summary

  • Add PaginationMeta model to parse pagination metadata from JSON:API meta response
  • Add queryItems support to the Request protocol and Service networking layer for URL query parameters
  • Update GetItemTagsRequest to accept optional page parameter and return ItemTagsResponse with pagination meta
  • Add reloadPage(shopId:page:) and loadNextPage(shopId:) to ItemTagRepository for paginated fetching
  • Add infinite scroll (load more) row in ItemTagListView with ProgressView spinner
  • ShopDetailView continues fetching all items without pagination for backward compatibility
  • Add comprehensive tests for PaginationMeta and new ItemTagListViewModel pagination behavior

Test plan

  • make lint passes (0 violations)
  • Build succeeds
  • All PaginationMetaTest tests pass (8 tests)
  • All ItemTagListViewModelTest tests pass (including new pagination tests)
  • Manual test: item tag list loads first page, scrolling to bottom loads next page
  • Manual test: pull-to-refresh resets to page 1
  • Manual test: ShopDetailView still loads all items without pagination

🤖 Generated with Claude Code

dadachi and others added 2 commits April 3, 2026 16:31
Add PaginationMeta model, query parameter support in networking layer,
and infinite scroll in ItemTagListView. ShopDetailView continues
fetching all items without pagination for backward compatibility.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dadachi dadachi merged commit cc42132 into main Apr 3, 2026
2 checks passed
@dadachi dadachi deleted the pagination-item-tags branch April 3, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant