Silence success toasts on item-tag complete/idle in ShopDetailView#44
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 25, 2026
Merged
Conversation
Ports nativeapptemplate/NativeAppTemplate-iOS#52. The swipe action already reflects the state change via ShopDetailCardView's re-render after reload(); the extra success toast was redundant noise. Errors still post to the message bus so users still see feedback when something actually fails. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports nativeapptemplate/NativeAppTemplate-iOS#52. The swipe action on
ShopDetailViewalready reflects the state change viaShopDetailCardView's re-render afterreload(); the extra success toast (itemTagCompleted/itemTagIdled) was redundant noise. Errors still post to the message bus, so users still see feedback when something actually fails.Changes
ShopDetailViewModel.completeTag/idleTag: dropped the success `messageBus.post(...)` calls.ShopDetailViewModelTest.completeTag/idleTag: now assert `currentMessage == nil` on success (failure tests unchanged).Constants.swift: removed the now-unused `itemTagCompleted` / `itemTagIdled` strings; kept the `*Error` variants.Test plan
🤖 Generated with Claude Code