Add client-side length caps + truncation for Shop name/description#50
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 27, 2026
Merged
Conversation
Ports nativeapptemplate/NativeAppTemplate-iOS#60. Mirror the ItemTag pattern from PR #49 for Shop. Server has no caps on Shop name/description; this is a client-only UX guard. - Constants: maximumShopNameLength = 100, maximumShopDescriptionLength = 1_000. New strings: shopNameIsInvalid, shopDescriptionIsInvalid, plus shopNameHelp(maximumLength:) / shopDescriptionHelp(maximumLength:) parametric helpers. - ShopCreateViewModel + ShopBasicSettingsViewModel: split hasInvalidData into hasInvalidDataName + hasInvalidDataDescription, expose maximumNameLength / maximumDescriptionLength, add validateNameLength() / validateDescriptionLength(). - ShopCreateView + ShopBasicSettingsView: wire .onChange truncation on Name and Description; switch to two-line footer (always-visible help + conditional red "is invalid" text), matching ItemTagCreateView. - Tests: added maximumNameLength, maximumDescriptionLength, parametric nameValidation / descriptionValidation, and the two truncation tests on both viewmodel test suites; replaced the old simple hasInvalidData(name:) parametric test in ShopCreateViewModelTest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports nativeapptemplate/NativeAppTemplate-iOS#60. Mirror the ItemTag pattern from #49 for Shop. Server has no caps on Shop name/description; this is a client-only UX guard.
Test plan
🤖 Generated with Claude Code