swiftlint: run on every PR (drop paths filter)#70
Merged
Conversation
The previous `paths:` filter only triggered SwiftLint on changes to .swiftlint.yml, the workflow itself, or *.swift files. But the branch- protection rule on main marks SwiftLint as a required check — when a PR doesn't touch any of those paths (e.g. a .xcscheme move, gitignore tweak, README edit), SwiftLint never runs and the PR is stuck in BLOCKED state because the required check has no status. Standard pattern for required checks is to run on every PR. The cost is ~30s per PR for an action that early-exits on no-Swift-changed. Worth it to avoid silent merge-blockage on infrastructure PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dadachi
added a commit
that referenced
this pull request
May 8, 2026
dadachi
added a commit
that referenced
this pull request
May 8, 2026
* Make default scheme shared so generated projects ship with one Move NativeAppTemplate.xcscheme from xcuserdata/<user>/xcschemes/ to xcshareddata/xcschemes/. xcuserdata is gitignored (correctly — it holds per-developer Xcode state) which means anyone cloning fresh opens the project without a scheme until Xcode auto-creates a default one. The auto-default omits the run-time environment variable injection (NATIVEAPPTEMPLATE_API_DOMAIN etc.) the substrate relies on, so the app falls back to api.nativeapptemplate.com and dev workflows break silently. Shared schemes are conventional for any project meant to be cloned by others — no per-user state in the file, just the build/run/test configuration. Promoting the default scheme costs nothing and makes the substrate work out-of-the-box for fresh clones, including the nativeapptemplate-agent code generator's ./out/<slug>/ios/ outputs (the agent's iOS worker copies the substrate but skips xcuserdata; it does NOT skip xcshareddata, so the moved scheme rides along). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * trigger CI re-run after #70 (swiftlint workflow fix) landed --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
paths:filter only triggered SwiftLint on changes to.swiftlint.yml, the workflow itself, or*.swiftfiles. Branch protection onmainmarks SwiftLint as a required check — when a PR doesn't touch any of those paths (e.g. a.xcschememove,.gitignoretweak, README edit), SwiftLint never runs and the PR is stuck inBLOCKEDstate because the required check has no status.Standard pattern for required checks is to run on every PR. Cost is ~30s per PR for an action that early-exits when no Swift files changed. Worth it to avoid silent merge-blockage on infrastructure PRs.
Surfaced by #69 (move default scheme to xcshareddata) — same kind of issue will hit any future non-Swift-touching PR.
Test plan
.github/workflows/swiftlint.ymlso it triggers SwiftLint regardless of the change here (the workflow file path is in the filter)🤖 Generated with Claude Code