fix(visual2): Layer 1 build-output skip + Stage 2 crash-guard#86
Merged
Conversation
PR #84 made rename.rb skip app/assets/builds + public/assets (build output regenerated from un-renamed source, e.g. Turbo's visitCompleted in application.js). But Layer 1's scan skip-set didn't include those paths, so it scanned the bundle rename deliberately left alone and flagged the intentionally-un-renamed tokens. A real VISUAL=2 sentova run hit this: rails Layer 1 FAIL (9 leftover "Completed") — all from visitCompleted×7 + visitRequestCompleted×2 in the skipped application.js. The two skip lists had drifted. Add SKIP_SUBPATHS (app/assets/builds, public/assets) to layer1.ts walk so Layer 1 ignores exactly what rename.rb ignores. Real-source leftovers are still flagged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mobile-mcp runs in a child process; if it exits mid-walk the SDK rejects with "McpError: Connection closed". That was unhandled, so it aborted dispatch before buildRunReport — losing the entire report (and, in a multi-run session, everything after it). Wrap the Stage 2 walk in runStage2Phase: any throw degrades to a recorded Stage 2 failure on the walked platforms (pass:false + error), so the run still produces a report with Stage 2 marked failed instead of crashing. Surfaced by a real VISUAL=2 sentova run that crashed at Stage 2 and wrote no report. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two robustness fixes surfaced by a real
VISUAL=2run (sentova, paid substrate). Independent — one commit each.1.
fix(layer1): skip compiled build output to matchrename.rb(#84)#84 made
rename.rbskipapp/assets/builds+public/assets(build output regenerated from un-renamed source — e.g. Turbo'svisitCompletedinapplication.js). But Layer 1's scan didn't skip those paths, so it scanned the bundle rename deliberately left alone and flagged the intentionally-un-renamed tokens — the two skip lists had drifted.The run hit exactly this: rails Layer 1 FAIL (9 leftover
Completed) =visitCompleted×7 +visitRequestCompleted×2 in the skippedapplication.js.Fix: add
SKIP_SUBPATHS(app/assets/builds,public/assets) tolayer1.ts's walk. Real-source leftovers are still flagged (covered by a new test).2.
fix(judge): a Stage 2 mobile-mcp failure must not crash the runmobile-mcp runs in a child process; if it exits mid-walk the SDK rejects with
McpError: Connection closed. That was unhandled → it aborteddispatchbeforebuildRunReport, so the run wrote no report at all (and, in a paid→free session, the free run never started).Fix: wrap the Stage 2 walk so any throw degrades to a recorded Stage 2 failure (
pass:false+error) on the walked platforms — the run still produces a report with Stage 2 marked failed.Testing
npm run ci→ 73/73.runStage2Visualisn't injectable without a refactor; verified by the next real run.)Not included (separate, environment)
The run also exposed a
:3000collision — the developer's substrate dev server (nativeapptemplateapi) occupies the same host:port the agent bridges into the generated app and tries to bind. That's an environment issue (stop the substrate server before aVISUAL=2run); a longer-term "run the generated server on a free port" improvement is worth a separate issue.🤖 Generated with Claude Code