Fix push notification delivery crashing on send#71
Merged
Conversation
ItemTagNotifier's action_push_native config omitted the with_apple,
with_google, and with_data options. Noticed's delivery method passes
each to ActionPushNative, which does {}.merge(option) and raises
TypeError (no implicit conversion of nil into Hash) when the option is
nil. Provide the options (empty hashes for apple/google, the url payload
for data), matching Noticed's canonical config.
That crash masked a second bug: url referenced
api_v1_shopkeeper_shop_item_tag_path, which does not exist because
item_tags is declared shallow. Use the shallow helper
api_v1_shopkeeper_item_tag_path.
Existing tests only enqueued the notification and never performed the
delivery job, so neither bug surfaced. Add a test that performs the
delivery (excluding the real APNs/FCM send job) plus a test pinning the
url to the shallow route.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Push delivery via
ItemTagNotifierraisedTypeError (no implicit conversion of nil into Hash)in the Noticedaction_push_nativejob. Two stacked bugs:with_apple,with_google, andwith_data. Noticed's delivery method passes each toActionPushNative, which does{}.merge(option)and raises when the option isnil. Now provided (empty hashes for apple/google, theurlpayload for data), matching Noticed's canonical config.urlcalledapi_v1_shopkeeper_shop_item_tag_path, which doesn't exist:item_tagsis declaredshallow: true(config/routes.rb:49-50), so the show route isapi_v1_shopkeeper_item_tag_path(id). Fixed.Not caused by the noticed v2→v3 bump — the v2.9.3 delivery method was byte-identical; push simply hadn't run end-to-end until credentials landed.
Tests
Existing notifier tests only enqueued the notification and never performed the delivery job, so neither bug surfaced. Added:
urlto the shallow item_tag route.Test plan
bin/rubocop— no offensesbin/rails test— 426 runs, 889 assertions, 0 failures🤖 Generated with Claude Code