This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Windows: correctly set notifications name - not electron.app.YOURAPPNAME#1394
Merged
ronjouch merged 4 commits intonativefier:masterfrom Apr 21, 2022
Merged
Windows: correctly set notifications name - not electron.app.YOURAPPNAME#1394ronjouch merged 4 commits intonativefier:masterfrom
ronjouch merged 4 commits intonativefier:masterfrom
Conversation
ronjouch
reviewed
Apr 18, 2022
Contributor
ronjouch
left a comment
ronjouch
left a comment
There was a problem hiding this comment.
Neat, thanks! Just two nits and I'll merge this.
Contributor
Author
I think I've done it correctly if you can verify please? |
Forgot to import
ronjouch
changed the title
Contributor
@si458 perfect. Merging, will ship with the next release, in a few days/weeks. Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…AME (PR nativefier#1394) This sets the name correctly for Windows notifications. Currently, notifications name shows as `electron.app.YOURAPPNAME`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this helps with setting the the name correctly for windows notifications
currently it shows as
electron.app.YOURAPPNAMEyou need to run this command aswell as starting the app from the start menu or shortcut
https://www.electronjs.org/docs/latest/tutorial/notifications#windows