Skip to content

Malformed data due to data.classe() return undefined #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Malformed data due to data.classe() return undefined #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f29188
fix issue #56 data.class() return undefined
kefahB Jan 18, 2020
cdf54f8
Update package.json
kefahB Jan 18, 2020
0951fd0
Typescript fix
kefahB Jan 18, 2020
847ddab
Update https.ios.ts
kefahB Jan 18, 2020
42c17d2
Authorize utf-8 to be set on Content-Type
kefahB Jan 23, 2020
aa1a00f
Update https.ios.ts
kefahB Jan 23, 2020
1961e5e
Update https.ios.ts
kefahB Jan 23, 2020
efecf79
Update https.ios.ts
kefahB Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/https.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function AFSuccess(resolve, task: NSURLSessionDataTask, data: NSDictionary<strin
let content: any;
if (data && data.class) {
// console.log('data.class().name', data.class().name)
if (data.enumerateKeysAndObjectsUsingBlock || data.class().name === 'NSArray') {
if (data.enumerateKeysAndObjectsUsingBlock || (<any>data) instanceof NSArray) {
// content = {}
// data.enumerateKeysAndObjectsUsingBlock(function(k, v) {
// console.log('v.description', v.description)
Expand All @@ -53,7 +53,7 @@ function AFSuccess(resolve, task: NSURLSessionDataTask, data: NSDictionary<strin
let serial = NSJSONSerialization.dataWithJSONObjectOptionsError(data, NSJSONWritingOptions.PrettyPrinted);
content = NSString.alloc().initWithDataEncoding(serial, NSUTF8StringEncoding).toString();
// console.log('content', content)
} else if (data.class().name === 'NSData') {
} else if ((<any>data) instanceof NSData) {
content = NSString.alloc().initWithDataEncoding(data, NSASCIIStringEncoding).toString();
// } else if (data.class().name == 'NSArray') {
// content = []
Expand Down Expand Up @@ -136,12 +136,11 @@ function AFFailure(resolve, reject, task: NSURLSessionDataTask, error: NSError)
export function request(opts: Https.HttpsRequestOptions): Promise<Https.HttpsResponse> {
return new Promise((resolve, reject) => {
try {

const manager = AFHTTPSessionManager.alloc().initWithBaseURL(NSURL.URLWithString(opts.url));

if (opts.headers && opts.headers['Content-Type'] === 'application/json') {
manager.requestSerializer = AFJSONRequestSerializer.serializer();
manager.responseSerializer = AFJSONResponseSerializer.serializerWithReadingOptions(NSJSONReadingOptions.AllowFragments);
const contentType = (<string>opts.headers['Content-Type']).substring(0, 16);
if (opts.headers && contentType === 'application/json') {
manager.requestSerializer = AFJSONRequestSerializer.serializer();
manager.responseSerializer = AFJSONResponseSerializer.serializerWithReadingOptions(NSJSONReadingOptions.AllowFragments);
} else {
manager.requestSerializer = AFHTTPRequestSerializer.serializer();
// manager.responseSerializer = AFXMLParserResponseSerializer.serializer()
Expand Down
6 changes: 6 additions & 0 deletions src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@
"name": "Robert Laverty",
"email": "roblav96@gmail.com",
"url": "https://github.com/roblav96"
},
{
"name": "Kefah BADER ALDIN",
"email": "kefah.bader@gmail.com",
"url": "https://github.com/kefahB"
}

],
"repository": "github:gethuman/nativescript-https",
"homepage": "https://github.com/gethuman/nativescript-https",
Expand Down