Skip to content

Conversation

@lekhmanrus
Copy link
Contributor

Handle Angular params to form the correct URL.

@farfromrefug farfromrefug merged commit 33298e2 into nativescript-community:master Oct 19, 2023
@farfromrefug
Copy link
Member

@lekhmanrus thanks it is now released

@lekhmanrus
Copy link
Contributor Author

@farfromrefug thank you!

@lekhmanrus
Copy link
Contributor Author

Hey @@farfromrefug,
For some reason, v4.1.3 doesn't contain an angular folder. Maybe, has something changed in the build process?
See - v4.1.3 contains only 28 files, and v4.1.2 contains 42.

@farfromrefug
Copy link
Member

@lekhmanrus indeed:
there is a build error:

../../src/https/angular/ns-http-xhr-backend.ts:2:80 - error TS2459: Module '"@angular/common/http"' declares 'XhrFactory' locally, but it is not exported.

2 import { HttpErrorResponse, HttpEvent, HttpHeaders, HttpRequest, HttpResponse, XhrFactory } from '@angular/common/http';

any idea?
and there is another error. My build process does not stop on error...

@lekhmanrus
Copy link
Contributor Author

@farfromrefug,
Yep, in Angular v16 XhrFactory export from @angular/common/http has been removed. I'll fix that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants