Skip to content

Conversation

@CatchABus
Copy link
Contributor

This PR does few things based on event listeners.
More specifically:

  • Added support for adding event listeners in XML
  • Added descriptive on() call types for each event name
  • Replaced notify calls with existing sendEvent method
  • Removed unneeded hasListeners calls
  • Added generic type for data argument to sendEvent method
  • Fixed in issue that caused mapInteraction event data payload to be inconsistent between the two platforms
  • Replaced ClickType structures with a pure ClickType enum
  • Click event clickType will now return an integer for both platforms which can be compared with new enum values (this required an additional JNI call of swigValue() on android)

@CatchABus CatchABus marked this pull request as ready for review December 16, 2024 12:28
@farfromrefug
Copy link
Member

@CatchABus very nice looks good to me!
BTW to make a new release i need to figure out how to "release" the native side, or more precisely how to make gradle/pod use my releases on github. master is now based on my fork of the carto SDK so we should not use old releases from carto

@farfromrefug farfromrefug merged commit 96660b4 into master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants