feat: support adding images from HTTP and base64 data URLs #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notclive
changed the title
notclive
commented
Dec 7, 2023
| } | ||
|
|
||
| if (!image.startsWith('res://')) { | ||
| image = path.join(knownFolders.currentApp().path, image.replace('~/', '')); |
Contributor
Author
There was a problem hiding this comment.
This replacement of ~/ is already part of the nativescript library: https://github.com/NativeScript/NativeScript/blob/main/packages/core/image-source/index.android.ts#L120
Member
|
@notclive looks really nice! did you had the chance to test it on iOS and android ? |
Contributor
Author
|
Yes, tested on both Android and iOS (simulator) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently images must be defined at build time (as detailed in #56 and #48). This feature provides a mechanism to add dynamic images.