Skip to content

feat: click event for any layer types #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 9, 2020
Merged

feat: click event for any layer types #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1242ef3
feat: click event for any layer types
KG3RK3N Dec 4, 2020
e256c0d
Merge branch 'master' of https://github.com/nativescript-community/ui…
KG3RK3N Dec 7, 2020
e47662c
chore: add layer click event to some demo layers
KG3RK3N Dec 7, 2020
b75a28b
fix: wrong type of response on android queryRenderedFeatures
KG3RK3N Dec 7, 2020
66ce77b
chore: change signature of queryRenderedFeature to works more like ma…
KG3RK3N Dec 7, 2020
871c9bf
feat: add filter support on queryRenderedFeatures
KG3RK3N Dec 7, 2020
f76102e
chore: revert change signature of queryRenderedFeatures
KG3RK3N Dec 9, 2020
c9c1b3e
chore: revert remove feature interface.
KG3RK3N Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions demo/app/main-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,6 @@ export function onMapReady(args) {
])
.then(() => {
console.log('main-page Markers added');
setTimeout(() => {
map.queryRenderedFeatures({
point: {
lat: 52.360216,
lng: 4.889168,
},
}).then((result) => console.log(JSON.stringify(result)));
}, 1000);
})
.catch((error) => {
console.error('main-page: error adding markers:', error);
Expand Down
80 changes: 66 additions & 14 deletions demo/app/main-view-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,12 +426,31 @@ export class HelloWorldModel extends Observable {
source: {
type: 'geojson',
data: {
type: 'Feature',
properties: {},
geometry: {
type: 'Point',
coordinates: [4.823684692382513, 52.3701494345567],
},
type: 'FeatureCollection',
features: [
{
id: '1',
type: 'Feature',
properties: {
querySample: '1',
},
geometry: {
type: 'Point',
coordinates: [4.823684692382513, 52.3701494345567],
},
},
{
id: '2',
type: 'Feature',
properties: {
querySample: '2',
},
geometry: {
type: 'Point',
coordinates: [4.823684692382513, 52.3701494345567],
},
},
],
},
},
paint: {
Expand All @@ -444,7 +463,25 @@ export class HelloWorldModel extends Observable {
'circle-stroke-opacity': 0.75,
},
})
.then(() => console.log('circle-with-source-object added'));
.then(() => {
console.log('circle-with-source-object added');
this.mapbox.onMapEvent('click', 'circle-with-source-object', (features) => {
console.log('clicked', 'circle-with-source-object', features);
});

setTimeout(() => {
this.mapbox
.queryRenderedFeatures({
point: {
lat: 52.3701494345567,
lng: 4.823684692382513
},
layers: ['circle-with-source-object'],
filter: ['all', ['==', '$id', '2']],
})
.then((result) => console.log('query rendered features', JSON.stringify(result)));
}, 3000);
});

this.mapbox
.addLayer({
Expand Down Expand Up @@ -476,7 +513,12 @@ export class HelloWorldModel extends Observable {
'line-dash-array': [1, 1, 1, 1],
},
})
.then(() => console.log('line-with-source-object added'));
.then(() => {
console.log('line-with-source-object added');
this.mapbox.onMapEvent('click', 'line-with-source-object', (features) => {
console.log('clicked', 'line-with-source-object', features);
});
});

this.mapbox
.addLayer({
Expand Down Expand Up @@ -510,7 +552,12 @@ export class HelloWorldModel extends Observable {
'fill-translate-anchor': 'map',
},
})
.then(() => console.log('fill-with-source-object added'));
.then(() => {
console.log('fill-with-source-object added');
this.mapbox.onMapEvent('click', 'fill-with-source-object', (features) => {
console.log('clicked', 'fill-with-source-object', features);
});
});

await this.mapbox.addImage('bee', 'res://bee');
await this.mapbox.addImage('pizza', '~/assets/pizza-slice.png');
Expand All @@ -532,7 +579,12 @@ export class HelloWorldModel extends Observable {
'text-color': '#d6c80d',
},
})
.then(() => console.log('symbol-with-source-object added'));
.then(() => {
console.log('symbol-with-source-object added');
this.mapbox.onMapEvent('click', 'symbol-with-source-object', (features) => {
console.log('clicked', 'symbol-with-source-object', features);
});
});

this.mapbox
.addLayer({
Expand Down Expand Up @@ -567,10 +619,10 @@ export class HelloWorldModel extends Observable {

public doRemoveLayerAndSource(): void {
Promise.all([
this.mapbox.removeLayer('circle-with-source-object'),
this.mapbox.removeLayer('line-with-source-object'),
this.mapbox.removeLayer('fill-with-source-object'),
this.mapbox.removeLayer('symbol-with-source-object'),
this.mapbox.removeLayer('circle-with-source-object').then(() => this.mapbox.offMapEvent('click', 'circle-with-source-object')),
this.mapbox.removeLayer('line-with-source-object').then(() => this.mapbox.offMapEvent('click', 'line-with-source-object')),
this.mapbox.removeLayer('fill-with-source-object').then(() => this.mapbox.offMapEvent('click', 'fill-with-source-object')),
this.mapbox.removeLayer('symbol-with-source-object').then(() => this.mapbox.offMapEvent('click', 'symbol-with-source-object')),
this.mapbox.removeLayer('symbol-with-source-object2'),
]).then(() => {
return Promise.all([
Expand Down
Loading