Skip to content

translate to KO; init and introduction #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rigor789 merged 15 commits into from
Feb 28, 2018
Merged

translate to KO; init and introduction #47

rigor789 merged 15 commits into from
Feb 28, 2018

Conversation

@qgp9
Copy link
Contributor

@qgp9 qgp9 commented Feb 27, 2018

I made an initial environment for Korean translation with an introduction page.
Please review and merge this.

@nativescript-vue-bot
Copy link

nativescript-vue-bot commented Feb 27, 2018 •
edited
Loading

Deploy preview for nativescript-vue ready!

Built with commit 00f5210

https://deploy-preview-47--nativescript-vue.netlify.com

@rigor789
Copy link
Member

rigor789 commented Feb 27, 2018

Looks good, and feel free to remove contributors from the front-matter, since we can't really track all contributors throughout all languages, so as you go and translate a page, just remove everyone and keep yourself in the list.

I have to add a z-index for the language menu (like I did with the community menu) because right now you can't click the language.

Also you may need to create the landing page (index_ko.ejs) and set the dest to ko/index.html

@qgp9
Copy link
Contributor Author

qgp9 commented Feb 27, 2018

@rigor789 Is content/index_ko.ejs same as content/index.ejs a good place?

@rigor789
Copy link
Member

rigor789 commented Feb 27, 2018

Yes, you can just copy it and rename it

@rigor789
Copy link
Member

rigor789 commented Feb 27, 2018

I've pushed a fix for the language selector z-index, can you merge master into your branch?

rigor789
rigor789 reviewed Feb 27, 2018
View reviewed changes
build/index.js Outdated
moment,
localeMap: {
'en': 'English',
'ko': 'Korean',
Copy link
Member

@rigor789 rigor789 Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to use Korean here

Copy link
Contributor Author

@qgp9 qgp9 Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Done

@qgp9
Copy link
Contributor Author

qgp9 commented Feb 27, 2018

@rigor789 merging from upstream/master has been done :-)

@qgp9
Copy link
Contributor Author

qgp9 commented Feb 28, 2018

Done! :-D

@rigor789
Copy link
Member

rigor789 commented Feb 28, 2018

Woah! Great job, I'm merging now!

@rigor789 rigor789 merged commit 9dd047d into nativescript-vue:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rigor789 rigor789 rigor789 left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qgp9 @nativescript-vue-bot @rigor789