fix: add warning for lightningcss@1.30.2 #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a warning mechanism to detect and prevent the use of lightningcss version 1.30.2, which contains a critical bug that breaks compilation. The change implements version checking logic that throws an error when the problematic version is detected.
Key changes:
- Added version detection for lightningcss package to prevent usage of buggy version 1.30.2
- Moved ESLint disable comment to file level for better code organization
| ) as typeof import("lightningcss"); | ||
|
|
||
| try { | ||
| const lightningcssPackageJSONPath = require.resolve("../../package.json", { |
There was a problem hiding this comment.
The require.resolve path '../../package.json' is incorrect for resolving the lightningcss package.json. It should be 'lightningcss/package.json' to resolve the actual lightningcss package's package.json file.
Suggested change
| const lightningcssPackageJSONPath = require.resolve("../../package.json", { | |
| const lightningcssPackageJSONPath = require.resolve("lightningcss/package.json", { |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marklawlor
deleted the
10-11-fix_add_warning_for_lightningcss_1.30.2-recreation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.