perf: use reflect to test equity of message headers#1814
Closed
Aden-Q wants to merge 1 commit intonats-io:mainfrom
Closed
perf: use reflect to test equity of message headers#1814Aden-Q wants to merge 1 commit intonats-io:mainfrom
Aden-Q wants to merge 1 commit intonats-io:mainfrom
Conversation
Collaborator
|
Hello @Aden-Q - thanks for the contribution, but I am not sure about this - using reflection has its inherent cost, and while it's true that e.g. if we're comparing the same underlying object it may be faster, for more standard comparison (different header contents), it has worse performance. Take this benchmark: func BenchmarkMsgEqual(b *testing.B) {
b.StopTimer()
s := RunDefaultServer()
defer s.Shutdown()
nc := NewDefaultConnection(b)
defer nc.Close()
m1 := &nats.Msg{
Subject: "foo",
Data: []byte("Hello World"),
Header: nats.Header{
"foo": []string{"bar"},
},
}
m2 := &nats.Msg{
Subject: "foo",
Data: []byte("Hello World"),
Header: nats.Header{
"bar": []string{"baz", "quxx"},
},
}
b.StartTimer()
b.ReportAllocs()
for i := 0; i < b.N; i++ {
m1.Equal(m2)
}
}These are the results with the current implementation (no reflection): And with your changes (using reflection): Also note that using reflection we also add allocations. |
Author
|
Hi @piotrpio, thanks for taking a look and benchmarking it. Agreed that reflection is a less efficient fallback for complex data structure due to reflection overhead. While the current implementation performs better. Closing this. Thanks for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch uses reflection to test equality of message headers. This apporach is more efficient in the case when:
m.Headerandmsg.Headerare non-nilm.Headerandmsg.Headershare the same underlying object, so the equality can be caught before testing the content of the map, compared to the original approach. For reference, map reflect implementation in go source code: