Skip to content

go1.18 started to panic when ticker.Reset(0) is called #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mash merged 1 commit into from
Apr 5, 2022
Merged

go1.18 started to panic when ticker.Reset(0) is called #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions firequeue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ func (q *Queue) Loop(ctx context.Context) error {
func (q *Queue) loop(ctx context.Context) {
var bf = backoff.NewExponentialBackOff()
bf.MaxElapsedTime = 0
var nextInterval time.Duration = 0
// Use 1 instead of 0 because time.NewTicker disallow zero
// Use 1 instead of 0 because time.NewTicker and ticker.Reset disallow zero
var nextInterval time.Duration = 1
ticker := time.NewTicker(1)
defer ticker.Stop()

Expand Down Expand Up @@ -244,7 +244,7 @@ func (q *Queue) put(bf backoff.BackOff) time.Duration {
q.retrySuccessCount.Add(1)
bf.Reset()
// go to the next immediately when jobs are still in the queue
return 0
return 1
}

func (q *Queue) len() int {
Expand Down