Conversation
The previous Note said node_label/node_hash default to "unknown" when called on a non-contextualized observer; the actual default is "" (empty string). Also upgrades the Note to a Warning and adds a concrete correct- usage example showing that contextualize() must be called first, mirroring how FunctionNode.execute uses the API. Relates to ENG-299. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Replace every RST cross-reference role (:class:, :meth:, :func:, :exc:, :attr:, ~-prefixed names) and directive (.. note::) with their Google-style equivalents (plain backtick names, Note: sections) across 11 source files. No logic changes; package imports and all 328 tests pass unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eywalker
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoteinLoggingObserver.create_packet_logger: it saidnode_label/node_hashdefault to"unknown"when called on the root observer; the actual default is""(empty string).Note:to aWarning:, making the misuse consequence explicit.contextualize()must be called first, consistent with howFunctionNode.executeuses the API.Context (ENG-299)
ENG-299 traced empty
_log_node_label/_log_node_hashcolumns to callers invokingcreate_packet_loggeron a non-contextualized observer. The docstring previously downplayed this as a note with wrong default values, which made the constraint easy to miss. This PR makes the contract clear and accurate.The root cause fix (missing
contextualize()calls inportolan/tests/conftest.py) is addressed via a PR review comment on nauticalab/portolan#5.Test plan
uv run pytest tests/test_pipeline/— 328 passed)""default and the mandatorycontextualize()callRelates to ENG-299.
🤖 Generated with Claude Code