Conversation
Protocol declares Sequence[tuple[TagProtocol, PacketProtocol]] to accurately reflect ordered, indexable semantics without over-constraining implementations. The concrete StreamBase implementation narrows further to list[tuple[TagProtocol, PacketProtocol]] since it returns a list comprehension. Closes PLT-1179 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
eywalker
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamProtocol.flow) return type narrowed fromCollection[tuple[...]]toSequence[tuple[TagProtocol, PacketProtocol]]— callers using only the protocol can assume ordered, indexable access but not a specific concrete typeStreamBase.flow) narrowed further tolist[tuple[TagProtocol, PacketProtocol]]— accurately reflects that the method returns a list comprehensionSequencetocollections.abcimports in both affected files;Collectionretained for other usagesCloses PLT-1179
Test plan
test_hashing/test_storedirs are unrelated🤖 Generated with Claude Code