Skip to content

Improve hashing implementation, add convenience methods and add tutorial on Tracker usage#4

Merged
guzman-raphael merged 23 commits intonauticalab:mainfrom
eywalker:main
May 7, 2025
Merged

Improve hashing implementation, add convenience methods and add tutorial on Tracker usage#4
guzman-raphael merged 23 commits intonauticalab:mainfrom
eywalker:main

Conversation

@eywalker
Copy link
Copy Markdown
Contributor

@eywalker eywalker commented May 3, 2025

  • Improved hash implementation on Operation so now that identical hash is returned if two operations are identical in effect (i.e., two separate instances of an identical operation configured identically will return the same hash)
  • Added a notebook to demonstrate the use of Tracker including the DEFAULT_TRACKER.
  • Added new features to simplify common operations such as MapPackets and MapTags as well as FunctionPod creation. Added a notebook to describe these features.
  • Separate data storage from PodFunction implementation. Data storage is now implemented using dependency injection pattern, allowing for easy expansion to future storage solutions.

@eywalker eywalker requested review from Synicix and guzman-raphael May 3, 2025 03:45
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eywalker eywalker changed the title Improve hashing implementation and add tutorial on Tracker usage Improve hashing implementation, add convenience methods and add tutorial on Tracker usage May 4, 2025
@eywalker eywalker mentioned this pull request May 5, 2025
Copy link
Copy Markdown
Contributor

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eywalker! 💪

This makes sense but I'll admit it is much more "functional" than I was expecting for how I was planning on using the orcabridge playground. That's a good thing because I have plenty to go off of to understand your thinking/logic but I''d want to review it a bit more carefully.

To not hold up everything, I'll go ahead with it. I imagine as I start contributing it will probably start off fairly independent with the idea of eventually meeting/integrating with the rest once I've gotten a better sense of all the features you've already added.

@guzman-raphael guzman-raphael merged commit 68ef57c into nauticalab:main May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants