Improve hashing implementation, add convenience methods and add tutorial on Tracker usage#4
Merged
guzman-raphael merged 23 commits intonauticalab:mainfrom May 7, 2025
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Merged
guzman-raphael
approved these changes
May 7, 2025
Contributor
guzman-raphael
left a comment
There was a problem hiding this comment.
Thanks @eywalker! 💪
This makes sense but I'll admit it is much more "functional" than I was expecting for how I was planning on using the orcabridge playground. That's a good thing because I have plenty to go off of to understand your thinking/logic but I''d want to review it a bit more carefully.
To not hold up everything, I'll go ahead with it. I imagine as I start contributing it will probably start off fairly independent with the idea of eventually meeting/integrating with the rest once I've gotten a better sense of all the features you've already added.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashimplementation onOperationso now that identical hash is returned if two operations are identical in effect (i.e., two separate instances of an identical operation configured identically will return the samehash)Trackerincluding theDEFAULT_TRACKER.MapPacketsandMapTagsas well asFunctionPodcreation. Added a notebook to describe these features.PodFunctionimplementation. Data storage is now implemented using dependency injection pattern, allowing for easy expansion to future storage solutions.