-
Notifications
You must be signed in to change notification settings - Fork 0
feat: enable playwright artifacts and screenshot protocol #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you update the PR with the description of what you changed? |
KayTV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| **Screenshot Protocol:** | ||
| - Take a screenshot after completing all fields on a page | ||
| - Use fullPage: true to capture the complete viewport including off-screen content | ||
| - Do NOT take screenshots for individual form interactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a note I have is not taking screenshots of security risk ones like SSN. Most forms will hide this after they enter in their SSN with *** but there are less technical advance forms that do not have this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I agree, the defensible approach is to not take a screenshot. However if the form is a single page this means we are not able to visually confirm.
There are targeted approaches to taking screenshots as well:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving as is for now based on standup conversation, but underscoring this as a security consideration along with other artifacts (traces, snapshots).
Ticket
Resolves: Enable Playwright artifact storage across environments
Changes
artifacts/enabled via--output-dir--save-sessionand--save-tracefor full artifact storingsrc/mastra/mcp.tsfullPage: true) screenshot after completing each benefits application page, not per interactionsrc/mastra/agents/web-automation-agent.tsContext for reviewers
We need consistent, reviewable browser automation output (screenshots, traces, sessions)
Artifact Storage Locations