Skip to content

Conversation

@roehlerw
Copy link

Passes all tests except for one bonus test related to datetime. I compared the expected and my actual and it looked like they were the same so I am not sure why that fails.

Needs to have robust error handling added.

@SteveRuble
Copy link
Contributor

I've updated the host to compare dates correctly. I also added a more gnarly data file with only ten rows. For some reason your plugin publishes 21 rows from that file.

@roehlerw
Copy link
Author

roehlerw commented Nov 1, 2018

Added better schema inferring logic. It now looks at all records and picks the most common one for each column.
Added a check in publishing where it will not publish blank rows (caused garbage to publish 21 instead of 10 rows).
All tests pass except for garbage which really would benefit from allowing a user to input what each column's data type is supposed to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants