CLEANUP: Improve code clarity and consistency in AsyncArcusCommands#1086
Merged
Conversation
- Rename `verifyBKeyRange` to `verifyBKeyTypesMatch` for clarity - Remove redundant `result.set(true)` and update Javadoc in flush - Avoid redundant `arcusClientSupplier.get()` calls in constructor - Rename private `get` and `gets` to `getPerNode` and `getsPerNode` for clarity
oliviarla
approved these changes
Apr 30, 2026
jhpark816
reviewed
Apr 30, 2026
| public void receivedStatus(OperationStatus status) { | ||
| switch (status.getStatusCode()) { | ||
| case SUCCESS: | ||
| result.set(true); |
Collaborator
Author
There was a problem hiding this comment.
flush()는 응답이 왔다는 것 자체가 성공을 의미하므로 항상 true를 반환하기로 합의하였고, 이에 따라 combiner를 () -> true로 설정하였습니다.
따라서 개별 노드의 result에 값을 세팅하더라도 최종 결과에 영향을 주지 않습니다.
오히려 result.set(true)가 남아있으면 해당 값이 결과에 반영되는 것처럼 오해할 수 있어 제거하였습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
arcusClientSupplier.get()중복 호출 수정multiGet,multiGets에서 사용되던get,gets메서드를getPerNode,getsPerNode로 변경 (public API와 혼동 방지)flush(int delay)에서 combiner가 항상true를 반환하므로 불필요한result.set(true)제거 및 Javadoc 수정verifyBKeyRange→verifyBKeyTypesMatch로 변경하여 명확히 표현