This repository was archived by the owner on Apr 29, 2026. It is now read-only.
fix: pass resolved math sugar to codegen in REPL#392
Merged
navicore merged 1 commit intonavicore:mainfrom Apr 5, 2026
Merged
Conversation
The REPL engine was missing the extraction and passing of resolved arithmetic sugar from the typechecker to codegen. This meant math sugar operators like `>`, `<`, `+`, etc. were never resolved to their concrete forms (e.g., `i.>`, `f.+`) during REPL compilation, causing invalid LLVM IR generation and Clang compilation failures. The batch compiler in lib.rs already does this correctly. This commit mirrors that pattern in the REPL engine. Fixes navicore#391 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
@claude please review |
|
Claude Code is working… I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>,<,+,-,*,/,%,=,<=,>=,<>) were never resolved to their concrete forms (i.>,f.+, etc.) during REPL compilationTest plan
: longer-than-five? ( String -- Bool ) string.length 5 >;+,-,*,/,<,=Fixes #391
🤖 Generated with Claude Code