Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321
Summary
Rails を 6.1.7.10 → 7.0.10 にアップグレード。
変更内容
railsを~> 6.1.0→~> 7.0.0に更新dynamic_formgem を削除ActiveModel::ErrorsAPI 変更(eachが2引数→1引数)に非対応のためerror_messages_forヘルパーを自前で実装dynamic_form削除に伴う代替。model_name.humanを使い日本語モデル名を正しく表示errors.eachの2引数呼び出しを全箇所修正eachがErrorオブジェクトを1つ yield する仕様に変更Pattern::Deal#save/save!のシグネチャ修正save(*)→save(**options)+return削除。Rails 7 のtransaction内でreturnするとロールバックされるconfig.eager_load_paths +=→config.autoload_paths <<eager_load_pathsが freeze されるためconfig/initializers/libs.rbのASSET_KINDS初期化をafter_initializeに移動config.load_defaultsを6.1→7.0に更新Test plan
bundle exec rspec全426テスト通過(0 failures)