Skip to content

Mipmap Icons for Android#488

Merged
BrentDaMage merged 9 commits into
nbcraft-org:masterfrom
Vimd0:master
Feb 20, 2026
Merged

Mipmap Icons for Android#488
BrentDaMage merged 9 commits into
nbcraft-org:masterfrom
Vimd0:master

Conversation

@Vimd0
Copy link
Copy Markdown
Contributor

@Vimd0 Vimd0 commented Feb 18, 2026

App icons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have these different sizes in assets, then have them symlinked to here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we move the icons to /assets/app/icons

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we move the icons to /assets/app/icons

Is it even possible to do this for Android projects? I assumed they had to be in res/, with all their respected mipmap folders and values

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I said to just make a symlink

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have these different sizes in assets, then have them symlinked to here?

Didn't see the top comment. I'll do that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have these different sizes in assets, then have them symlinked to here?

The project will now automatically use the 'game/assets/app/icons' directory for the icons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do it like this. Just have game/assets/icons/icon_64x64.png, etc.

Copy link
Copy Markdown
Contributor Author

@Vimd0 Vimd0 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do it like this. Just have game/assets/icons/icon_64x64.png, etc.

To be recognized by Android Studio, the folders must be named as such. I renamed the folder to "mipmap" so we know it's for those icons

mipmap-icons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be recognized by Android Studio, the folders must be named as such.

That's why I said to symlink the icons.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be recognized by Android Studio, the folders must be named as such.

That's why I said to symlink the icons.

Ok. I linked the icons to be gotten from "mipmap" with thier icon_ names

Comment thread game/assets/icon_64x64.png Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in mipmap then

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in mipmap then

Did, and updated the .xlast to have the updated path

Comment thread game/assets/app/mipmap/icon_144x144.png Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, why is this in app/mipmap? it should be in app/icons/mipmap or something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread game/assets/app/icons/icon.jpg
@BrentDaMage
Copy link
Copy Markdown
Member

I would like to go in and fix the icon that's used for iOS builds in Xcode, but can't since you made your PR on your master branch. Do you have access to Xcode by chance? Or can you go into the Xcode project with Notepad and change the file path for icon.png?

@Vimd0
Copy link
Copy Markdown
Contributor Author

Vimd0 commented Feb 20, 2026

I would like to go in and fix the icon that's used for iOS builds in Xcode, but can't since you made your PR on your master branch. Do you have access to Xcode by chance? Or can you go into the Xcode project with Notepad and change the file path for icon.png?

  1. I already gave you access to my fork.
  2. I don't and can't access Xcode.
  3. I'm pretty sure I updated all ico paths. If not, what files should I edit?

@BrentDaMage
Copy link
Copy Markdown
Member

mcpe\platforms\macos\projects\Minecraft\Minecraft.xcodeproj\project.pbxproj

@Vimd0
Copy link
Copy Markdown
Contributor Author

Vimd0 commented Feb 20, 2026

mcpe\platforms\macos\projects\Minecraft\Minecraft.xcodeproj\project.pbxproj

Updated

@BrentDaMage BrentDaMage merged commit ec29651 into nbcraft-org:master Feb 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants