Conversation
Owner
Author
|
This gives a rough idea of how much slower math functions get: The answer is 20%; If instead we implemented math functions in a Go extension, they'd be about twice slower (like The alternative is to come up with an API to do "math functions" that doesn't involve multiple calls to get the type of values, and to return the result. Something similar might help the statistics aggregates, though their API is even more complex. All in all, 20% slower SQL trigonometry doesn't seem too high a price to pay to get rid of a dependency. I am much more willing to believe that |
edd06a2 to
c869191
Compare
223df1b to
579525d
Compare
c1a4433 to
41a2b56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems good enough to go (needs rebuilding the Wasm files).
All that's left to decide is if this is how I want to ship math functions, or if I'll get them from something like https://www.netlib.org/fdlibm/.
For math, this is somewhat slower, but one less dependency.
For everything else, this is a wash, but one less dependency.