Fix genomic coordinate incorrectly used as array index in quality array update#162
Merged
joshfactorial merged 1 commit intoncsa:developfrom Oct 2, 2025
Merged
Conversation
In `read_simulator.utils`, `apply_mutations` passed the genomic coordinates instead of the relative location of the mutation in the simulated read to `update_quality_array`, causing wrong or no quality scores to be updated. This commit corrects it by passing the relative location.
joshfactorial
requested changes
Oct 2, 2025
Collaborator
joshfactorial
left a comment
joshfactorial
left a comment
There was a problem hiding this comment.
Please change the target to develop. Once we've retested develop, we'll pull changes into main.
joshfactorial
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
read_simulator.utils,apply_mutationspassed the genomic coordinates instead of the relative location of the mutation in the simulated read toupdate_quality_array, causing wrong or no quality scores to be updated. This commit corrects it by passing the relative location.