review time series part 2 #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veroandreo
reviewed
Sep 22, 2024
Contributor
veroandreo
left a comment
veroandreo
left a comment
There was a problem hiding this comment.
I added something about temporal topology and relations. I prefer keeping the example removed, it's just a different way of trying to catch and maintain reader's attention
| ::: {.callout-note title="Setup"} | ||
| To run this tutorial locally or in Google Colab, you should install | ||
| GRASS GIS 8.4+, and download the | ||
| [daily MODIS LST project](https://zenodo.org/records/3564515). |
Contributor
There was a problem hiding this comment.
Suggested change
| [daily MODIS LST project](https://zenodo.org/records/3564515). | |
| [daily MODIS LST project](https://zenodo.org/doi/10.5281/zenodo.3564514). |
Comment on lines
+338
to
+340
| tmin = gs.list_grouped(type="raster", pattern="lst_minimum_*")["italy_LST_daily"] | ||
| tmax = gs.list_grouped(type="raster", pattern="lst_maximum_*")["italy_LST_daily"] | ||
| tavg = gs.list_grouped(type="raster", pattern="lst_average_*")["italy_LST_daily"] |
Contributor
There was a problem hiding this comment.
I needed numbers, that's why I used the ??. Does it do the right selection with the *?
Comment on lines
-225
to
-241
| :::{.callout-caution title="Question" collapse="true"} | ||
| How would you obtain the average spring warming over the whole time series? | ||
|
|
||
| ```{python} | ||
| # Average spring warming | ||
| gs.run_command("t.rast.series", | ||
| input="annual_spring_warming", | ||
| output="avg_spring_warming", | ||
| method="average") | ||
| # Display raster map with interactive class | ||
| spw_map = gj.InteractiveMap(width = 500, use_region=True, tiles="CartoDark") | ||
| spw_map.add_raster("avg_spring_warming") | ||
| spw_map.add_layer_control(position = "bottomright") | ||
| spw_map.show() | ||
| ``` | ||
| ::: |
Contributor
There was a problem hiding this comment.
I would not remove this example. The question is just a trigger for the next topic. It's a different way of introducing a topic. And in any case, it is collapsed so it is up the the reader to unfold it.
Comment on lines
+85
to
+86
| ::: {.callout-note title="Temporal relations"} | ||
| Something about temporal relations... |
Contributor
There was a problem hiding this comment.
Suggested change
| ::: {.callout-note title="Temporal relations"} | |
| Something about temporal relations... | |
| ::: {.callout-note title="Temporal topology"} | |
| Temporal topology refers to the temporal relations among time intervals or instances in different time series. They are mostly useful when sampling one STRDS with another (see [t.sample](https://grass.osgeo.org/grass-stable/manuals/t.sample.html) manual). Some examples of temporal relations are *start, equal, during, contain, overlap,* etc. See below a graphic representation of relations and sampling taken from Gebbert and Pebesma (2014). Note that A1 starts in S1, B3 is during S3, B4 equals S4, B1 overlaps S1. | |
|  | |
Contributor
There was a problem hiding this comment.
Dunno if attaching img like this really work...
veroandreo
added a commit
to veroandreo/grass-tutorials
that referenced
this pull request
May 22, 2025
Contributor
|
Closing this one, as suggestions are now included in OSGeo/grass-tutorials#57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely removed one of the examples within the callout questions, it was placed before the tool was introduced, which seemed problematic. It could be integrated later if needed.
I replaced the knitr engine for jupyter in the heading, my understanding is knitr is for R.