Skip to content

Add plugin priority and refactor for compatibility with napari-ndev legacy behavior#24

Merged
TimMonko merged 3 commits intondev-kit:mainfrom
TimMonko:feat/napari-ndev-compat
Nov 25, 2025
Merged

Add plugin priority and refactor for compatibility with napari-ndev legacy behavior#24
TimMonko merged 3 commits intondev-kit:mainfrom
TimMonko:feat/napari-ndev-compat

Conversation

@TimMonko
Copy link
Member

@TimMonko TimMonko commented Nov 25, 2025

References and relevant issues

This PR is needed to maintain behavior for using ndevio in napari-ndev in ndev-kit/napari-ndev#194

Description

  1. Adds bioio-tifffile to core dependencies, because, at least for now, this is needed for some awkward tiff files that can be read by bioio-imageio but result in bad metadata reading. Since there are currently no tifffile pins in any of the dependencies, this behavior will remain for now. It's worth considering in the future if this is really the way I want core dependencies going forward.
  2. This orders the plugin list to be used for infering the reader, because despite the installation order of plugins, some get installed before others (perhaps this is a uv thing, compared to pip). As such, I need a way to opinionatedly pick my preferred plugins, but the preferred plugin setting still gives the user an easy way to override if they can only find their desired behavior with a specific plugin. It will always fall back to the setting.
  3. Refactors determine_reader_plugin to mostly just rely on the plugin manager

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ndevio/_napari_reader.py 50.00% 2 Missing ⚠️
src/ndevio/nimage.py 75.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TimMonko TimMonko merged commit a0e2838 into ndev-kit:main Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant