Skip to content

feat: add transactions to location imports #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
takinbo merged 4 commits into from
Jun 22, 2020
Merged

feat: add transactions to location imports #724

takinbo merged 4 commits into from
Jun 22, 2020

Conversation

@dodumosu
Copy link
Collaborator

@dodumosu dodumosu commented Jun 18, 2020 •
edited
Loading

this pull request adds explicit transactions to locations import in order to deal with the recurrent issues encountered with imports
Edit

  • nested transactions enabled. if any of the inner ones fails, the outermost one is rolled back
  • import all data uploaded in Excel spreadsheets as strings

@dodumosu dodumosu requested a review from takinbo June 18, 2020 13:21
takinbo
takinbo approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@takinbo takinbo merged commit dbd1235 into nditech:develop Jun 22, 2020
@dodumosu dodumosu deleted the location-imports branch June 23, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takinbo takinbo takinbo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dodumosu @takinbo