Skip to content

Minor fixes #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
takinbo merged 2 commits into from
May 4, 2021
Merged

Minor fixes #792

takinbo merged 2 commits into from
May 4, 2021

Conversation

@dodumosu
Copy link
Collaborator

@dodumosu dodumosu commented Feb 17, 2021

this PR fixes some issues that came up during testing of the PWA:

  • error when editing an incident submission for a form with image fields
  • error when trying to update the unreachable status for the master submission for an incident submission

@dodumosu dodumosu requested a review from takinbo February 17, 2021 07:29
dodumosu added 2 commits April 20, 2021 11:40
@dodumosu
fix: skip update of master sub if none exists
08ca7ce
@dodumosu
fix: fix error when incidents have images
6514370 
this commit fixes an error that occurs when
an incident form has image fields
takinbo
takinbo approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@takinbo takinbo merged commit 9ad6b4e into nditech:develop May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takinbo takinbo takinbo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dodumosu @takinbo