Remove "Avoid NonEmpty.unzip" hint (fixes #1657)#1682
Closed
mgajda wants to merge 3 commits intondmitchell:masterfrom
Closed
Remove "Avoid NonEmpty.unzip" hint (fixes #1657)#1682mgajda wants to merge 3 commits intondmitchell:masterfrom
mgajda wants to merge 3 commits intondmitchell:masterfrom
Conversation
…1679) When suggesting record patterns, check if the constructor has type applications (e.g. @type). If it does, don't suggest the record pattern syntax since it would lose the type applications and produce invalid code. Added test cases: - foo (Bar _ _ _ _) = x -- Suggests Bar{} - foo (Bar @_ _ _ _) = x -- No suggestion (type app present) - foo (Bar @A @b _ _ _) = x -- No suggestion (multiple type apps) Example from issue: Before fix: Ast.AstScatterS @_ @Shn1 @shp1 _ _ _ _ _ Would suggest: Ast.AstScatterS {} (WRONG - loses @types) After fix: No suggestion (preserves correct code)
…dmitchell#1674) With OverloadedStrings extension, string literals become polymorphic. The hint to replace 'intercalate " "' with 'unwords' becomes incorrect because: - intercalate " " xs : polymorphic type (works with any IsString a) - unwords xs : requires [String] -> String (only works with String) Solution: - Moved intercalate/unwords rule from YAML patterns to code-based hint - Added extension state checking (OverloadedStrings) - Only suggest unwords when OverloadedStrings is NOT enabled Test cases: - Without OverloadedStrings: suggests unwords ✓ - With OverloadedStrings: no suggestion ✓
base >= 4.19 exposes `Data.Functor.unzip` and GHC warns about the `NonEmpty.unzip` form via `-Wx-data-list-nonempty-unzip` (core-libraries-committee/issues/258). The hlint hint is redundant with the compiler warning, fires on imports that are not `NonEmpty.unzip`, and cannot be CPP-gated per base version. Drops one line from data/hlint.yaml. Self-test: 970 tests, 3 pre-existing baseline failures, unchanged from master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1657.
base >= 4.19exposesData.Functor.unzipand GHC emits-Wx-data-list-nonempty-unzipfor theNonEmpty.unzipform (core-libraries-committee/issues/258). The hlint hint is redundant with the compiler warning, cannot be CPP-gated perbaseversion, and fires even whenunzipis imported fromData.Functorrather thanData.List.NonEmpty.One-line deletion in
data/hlint.yaml. Self-test: 970 tests, 3 pre-existing baseline failures, unchanged from master.