Skip to content

Default withAttrLayers to true for GeoJsonFolder #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MisterGC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Default withAttrLayers to true for GeoJsonFolder #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/mapget-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ Required fields:

Optional fields:

- `withAttrLayers`: boolean flag. If `true`, nested objects in the GeoJSON `properties` are interpreted as attribute layers; if `false`, only scalar top‑level properties are emitted.
- `withAttrLayers` (default: `true`): boolean flag. If `true`, nested objects in the GeoJSON `properties` are converted to mapget attribute layers; if `false`, only scalar top‑level properties are emitted and nested objects are silently dropped.

Example:

Expand Down
6 changes: 4 additions & 2 deletions libs/http-service/src/cli.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ nlohmann::json geoJsonFolderSchema()
}},
{"withAttrLayers", {
{"type", "boolean"},
{"title", "With Attribute Layers"}
{"title", "With Attribute Layers"},
{"description", "Convert nested GeoJSON property objects to mapget attribute layers. Default: true."},
{"default", true}
}}
}},
{"required", nlohmann::json::array({"folder"})},
Expand Down Expand Up @@ -233,7 +235,7 @@ void registerDefaultDatasourceTypes() {
"GeoJsonFolder",
[](YAML::Node const& config) -> DataSource::Ptr {
if (auto folder = config["folder"]) {
bool withAttributeLayers = false;
bool withAttributeLayers = true;
if (auto withAttributeLayersNode = config["withAttrLayers"])
withAttributeLayers = withAttributeLayersNode.as<bool>();
return std::make_shared<geojsonsource::GeoJsonSource>(folder.as<std::string>(), withAttributeLayers);
Expand Down
Loading