This repository was archived by the owner on Sep 6, 2025. It is now read-only.
Preserve the base URI when fixupXmlBase is false #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #28 If `fixupXmlBase` is false, there’s nothing in the document to preserve the base URI of an element when it’s nested inside other elements. In this case, we add a magic attribute to keep track and then do a second top-to-bottom pass to remove the magic attributes and set the base URIs correctly. There’s a time and space cost, but there doesn’t seem to be any other solution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28
If
fixupXmlBaseis false, there’s nothing in the document to preserve the base URI of an element when it’s nested inside other elements. In this case, we add a magic attribute to keep track and then do a second top-to-bottom pass to remove the magic attributes and set the base URIs correctly. There’s a time and space cost, but there doesn’t seem to be any other solution.