security(deps): bump hono to 4.12.14 and vite override to ^7.3.2#392
security(deps): bump hono to 4.12.14 and vite override to ^7.3.2#392
Conversation
Resolves all open Dependabot alerts on package-lock.json: - hono <4.12.14: JSX SSR HTML injection, cookie name bypass, IPv4-mapped IPv6 ipRestriction, setCookie validation, serveStatic repeated-slash bypass, toSSG path traversal (alerts #16, #18, #20, #22, #24, #26) - vite <7.3.2: dev server WebSocket arbitrary file read, optimized deps .map path traversal, server.fs.deny query bypass (alerts #12, #13, #14) Lockfile refreshed via npm install --package-lock-only. Typecheck, lint, and 3418/3418 tests pass.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 44 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes the 9 open Dependabot alerts on
package-lock.json:hono4.12.10 → 4.12.14 — closes alerts audit(ia): canonicalize command findability and docs taxonomy #16, fix: stabilize docs policy and clean-worktree validation #18, feat(api): add named-parameter overloads and contract docs #20, [AUD-D02] Add cross-process concurrency control for storage transactions #22, audit: deep full-surface hardening with atomic P1 fixes #24, docs: add ralph loop phased plan reference #26ipRestriction,getCookienon-breaking space bypass,hono/jsxSSR HTML injectionviteoverride^7.3.1→^7.3.2(transitive, dev-only via vitest) — closes alerts fix(storage): prevent re-login across PR worktrees #12, docs: deep documentation and repository professionalization audit #13, feat: unified overhaul — consolidate PRs #7, #8, #10, #11, #12, #13 #14.mappath traversal,server.fs.denyquery bypassChanges
package.json: bumpdependencies.hono,overrides.hono,overrides.vite.package-lock.json: regenerated vianpm install --package-lock-only --ignore-scripts(minimal diff, only the two packages).Validation
npm run typecheck— cleannpm run lint— cleannpm test— 225 files, 3418/3418 tests passnote: greptile review for oc-chatgpt-multi-auth. cite files like
lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.Greptile Summary
patches 9 dependabot alerts by pinning
honoto4.12.14(6 CVEs: path traversal, cookie bypass,ipRestrictionIPv4-mapped IPv6, JSX SSR injection) and raising theviteoverride to^7.3.2(3 dev-only CVEs). changes are minimal and correctly land in bothdependenciesandoverridesforhono.MIN_HONO_FLOORintest/lockfile-version-floor.test.tsis still"4.12.2"— the regression guard passes for any version in4.12.2–4.12.13, all of which carry the patched CVEs. it should be updated to"4.12.14".viteoverride, so a future regression below7.3.2would go undetected.Confidence Score: 4/5
safe to merge after updating MIN_HONO_FLOOR in the floor test; vite gap is P2 but the core security bump is correct
one P1 finding: MIN_HONO_FLOOR is stale and would allow regressions to any CVE-affected version in 4.12.2–4.12.13 without failing the guard test; the fix is a one-liner. the vite floor gap is P2 and doesn't block merge.
test/lockfile-version-floor.test.ts — MIN_HONO_FLOOR needs updating to 4.12.14
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Dependabot alerts #12-#26] --> B{Package} B -->|prod dep| C[hono 4.12.10] B -->|dev transitive| D[vite <7.3.2] C --> E[hono 4.12.14 CVE fixes: path traversal, cookie bypass, ipRestriction, JSX SSR injection] D --> F[vite 7.3.2 CVE fixes: WebSocket file read, .map traversal, fs.deny bypass] E --> G[package.json dependencies + overrides updated] F --> H[package.json overrides.vite updated] G --> I[package-lock.json regenerated] H --> I I --> J{Regression guard} J -->|MIN_HONO_FLOOR=4.12.2| K[stale — allows 4.12.2–4.12.13] J -->|vite floor| L[no test exists]Comments Outside Diff (1)
test/lockfile-version-floor.test.ts, line 6 (link)MIN_HONO_FLOORis still"4.12.2"— the floor test will pass for any version in the range4.12.2–4.12.13, all of which carry the CVEs this PR is patching (path traversal, cookie bypass, IPv6ipRestriction, JSX SSR injection). a future accidental downgrade to e.g.4.12.5would not be caught.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "security(deps): bump hono to 4.12.14 and..." | Re-trigger Greptile