fix: update remaining occurrences of old package name#15
Merged
Conversation
ndycode
added a commit
that referenced
this pull request
Apr 6, 2026
fix: update remaining occurrences of old package name
ndycode
added a commit
that referenced
this pull request
Apr 6, 2026
fix: update remaining occurrences of old package name
8 tasks
ndycode
added a commit
that referenced
this pull request
Apr 17, 2026
…redaction Phase-1 security hardening (audit d92a8ee). - lib/auth/login-runner.ts: extract mergeStoredAccountPair and switch credential fallback from || to ?? so an explicit empty-string token does not silently resurrect stale tokens (top-20 #10). - lib/auth/auth.ts: redirect URI uses the 127.0.0.1 loopback literal (OAUTH_CALLBACK_LOOPBACK_HOST) to match the server bind host per RFC 8252 sec 7.3. - lib/accounts.ts + lib/schemas.ts: validate the Codex CLI accounts file through CodexCliAccountsSchema (Zod) at the cross-process trust boundary; failures warn+skip instead of trusting ad-hoc typeof checks (top-20 #11). - lib/logger.ts: extend TOKEN_PATTERNS with keyed-extraction regexes for opaque OpenAI refresh/access/id tokens embedded in JSON response bodies (top-20 #15). Tests cover merge empty-token regression, 127.0.0.1 redirect URI, Codex CLI schema happy+malformed paths, and JSON token redaction.
ndycode
added a commit
that referenced
this pull request
Apr 17, 2026
…redaction Phase-1 security hardening (audit d92a8ee). - lib/auth/login-runner.ts: extract mergeStoredAccountPair and switch credential fallback from || to ?? so an explicit empty-string token does not silently resurrect stale tokens (top-20 #10). - lib/auth/auth.ts: redirect URI uses the 127.0.0.1 loopback literal (OAUTH_CALLBACK_LOOPBACK_HOST) to match the server bind host per RFC 8252 sec 7.3. - lib/accounts.ts + lib/schemas.ts: validate the Codex CLI accounts file through CodexCliAccountsSchema (Zod) at the cross-process trust boundary; failures warn+skip instead of trusting ad-hoc typeof checks (top-20 #11). - lib/logger.ts: extend TOKEN_PATTERNS with keyed-extraction regexes for opaque OpenAI refresh/access/id tokens embedded in JSON response bodies (top-20 #15). Tests cover merge empty-token regression, 127.0.0.1 redirect URI, Codex CLI schema happy+malformed paths, and JSON token redaction.
ndycode
added a commit
that referenced
this pull request
Apr 17, 2026
…redaction (#112) * fix(security): strict nullish merge + loopback URI + CLI zod + token redaction Phase-1 security hardening (audit d92a8ee). - lib/auth/login-runner.ts: extract mergeStoredAccountPair and switch credential fallback from || to ?? so an explicit empty-string token does not silently resurrect stale tokens (top-20 #10). - lib/auth/auth.ts: redirect URI uses the 127.0.0.1 loopback literal (OAUTH_CALLBACK_LOOPBACK_HOST) to match the server bind host per RFC 8252 sec 7.3. - lib/accounts.ts + lib/schemas.ts: validate the Codex CLI accounts file through CodexCliAccountsSchema (Zod) at the cross-process trust boundary; failures warn+skip instead of trusting ad-hoc typeof checks (top-20 #11). - lib/logger.ts: extend TOKEN_PATTERNS with keyed-extraction regexes for opaque OpenAI refresh/access/id tokens embedded in JSON response bodies (top-20 #15). Tests cover merge empty-token regression, 127.0.0.1 redirect URI, Codex CLI schema happy+malformed paths, and JSON token redaction. * fix(logger): use lastIndexOf to avoid masking key name instead of token value String.prototype.replace(string, string) only swaps the first occurrence. When a captured token value is a substring of the preceding key name (e.g. value �ccess inside �ccess_token), the first-occurrence replace corrupts the key and leaks the real value. Slice around lastIndexOf instead so the trailing captured value is always the target. Addresses Greptile P2 review on PR #112.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLUGIN_NAMEinscripts/install-opencode-codex-auth.jsto ensurenpxinstalls correctly.scripts/test-all-models.shto use the new package name.These changes ensure that the renome from
opencode-openai-codex-auth-multitooc-chatgpt-multi-authis complete and functional across all scripts and UI.