Clamp per-series retention overrides to server default#1
Merged
ne0ekspert merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
max_storage_byteswhich could exhaust disk.Description
Engine::register_seriesto clamp a client-providedmax_storage_bytestodefault_series_max_byteswhen a server default is configured, usingrequested_min(default)semantics and preservingNonesemantics when no default is set.max_storage_bytesand continue to persist the chosen limit into the manifest.register_series_clamps_client_limit_to_default_capthat registers a series with an oversized client limit and asserts the persistedmax_storage_bytesequals the configured default.Testing
cargo fmtsuccessfully.cargo test register_series_clamps_client_limit_to_default_cap -- --nocaptureand the test passed.cargo test evicts_oldest_segment_when_series_limit_is_exceeded -- --nocaptureand the test passed.Codex Task