chore: enhance mock attestation struct with conditional validation#1016
Merged
chore: enhance mock attestation struct with conditional validation#1016
Conversation
Base automatically changed from
dsharifi/use-test-assets-for-image-hash
to
main
September 4, 2025 17:23
netrome
approved these changes
Sep 8, 2025
pbeza
reviewed
Sep 8, 2025
pbeza
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_utilscrate for image hashes in contract tests #1013test_utilscrate for image hashes in contract tests #1013 is closed.Changes
LocalAttestation->MockAttestationto make it crystal clear that this is a mocked attestation.MockAttestationis now an enum with explanatory variantsMockAttestation::WithConstraintsto showcase how to use this enum ->new_hash_and_previous_hashes_under_grace_period_pass_attestation_verification. This test closes We should be able to re-validate a node running the old and new MPC image during the grace period, after updating the MPC docker image hash #730