Skip to content

chore: enhance mock attestation struct with conditional validation#1016

Merged
DSharifi merged 9 commits intomainfrom
dsharifi/enhance-local-attestation
Sep 8, 2025
Merged

chore: enhance mock attestation struct with conditional validation#1016
DSharifi merged 9 commits intomainfrom
dsharifi/enhance-local-attestation

Conversation

@DSharifi
Copy link
Copy Markdown
Contributor

@DSharifi DSharifi commented Sep 3, 2025

Changes

  • renamed LocalAttestation -> MockAttestation to make it crystal clear that this is a mocked attestation.
  • MockAttestation is now an enum with explanatory variants
pub enum MockAttestation {
    /// Always pass validation
    Valid,
    /// Always fails validation
    Invalid,
    /// Pass validation depending on the set constraints
    WithConstraints {
        mpc_docker_image_hash: Option<MpcDockerImageHash>,
        launcher_docker_compose_hash: Option<LauncherDockerComposeHash>,
        expiry_time_stamp_seconds: Option<u64>,
    },
}

@DSharifi DSharifi changed the title Dsharifi/enhance local attestation chore: enhance mock attestation struct with conditional validation Sep 3, 2025
@DSharifi DSharifi marked this pull request as ready for review September 4, 2025 00:20
@DSharifi DSharifi requested a review from netrome September 4, 2025 00:20
Base automatically changed from dsharifi/use-test-assets-for-image-hash to main September 4, 2025 17:23
@netrome netrome linked an issue Sep 8, 2025 that may be closed by this pull request
@DSharifi DSharifi requested a review from pbeza September 8, 2025 11:05
Comment thread crates/attestation/src/attestation.rs
Comment thread crates/attestation/src/attestation.rs Outdated
@DSharifi DSharifi enabled auto-merge September 8, 2025 14:23
@DSharifi DSharifi added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 9967e16 Sep 8, 2025
13 checks passed
@DSharifi DSharifi deleted the dsharifi/enhance-local-attestation branch September 8, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants