Conversation
DSharifi
changed the title
ed25519 prefix on node HTTP server.ed25519: prefix for public key serialization on node HTTP server.
DSharifi
changed the title
ed25519: prefix for public key serialization on node HTTP server.
DSharifi
changed the title
DSharifi
force-pushed
the
1226-near-key-endpoint-should-return-base58-encoded-public-keys
branch
from
58c3283 to
83b9461
Compare
netrome
reviewed
Oct 6, 2025
netrome
approved these changes
Oct 6, 2025
| .expect("base58 decode should work") | ||
| .try_into() | ||
| .expect("key must be decoded to 32 bytes"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Would be nice to complement these tests with a fixture test to ensure we don't accidentally modify the serialized representation. Also it would be nice to check that the serialization is consistent with the near_sdk::PublicKey one.
Collaborator
There was a problem hiding this comment.
Added the snapshot test in 99c6e8d. We don't have near_sdk in the workspace, so skipping it for now.
Edit: we do have it in the workspace. Don't know why I thought we didn't 😅 anyway not critical for now.
Collaborator
|
Updated and set to auto-merge. |
netrome
deleted the
1226-near-key-endpoint-should-return-base58-encoded-public-keys
branch
pbeza
reviewed
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1226