Conversation
gilcu3
force-pushed
the
gilcu3/breakout_pytests_premise_robust_ecdsa
branch
from
fc13241 to
1015c32
Compare
gilcu3
commented
Dec 16, 2025
Contributor
Author
There was a problem hiding this comment.
this file needs to be separated from metrics.py because there is a cyclic dependency (used in type annotations) between the MpcCluster type and the metrics helper functions defined here.
5 tasks
netrome
previously approved these changes
Dec 16, 2025
Comment on lines
+188
to
+191
| def kill_observer(observer: LocalNode): | ||
| observer.kill(gentle=True) | ||
| observer.reset_data() | ||
| adjust_indexing_shard(observer) |
Collaborator
There was a problem hiding this comment.
This is new right? Why do we need this?
Contributor
Author
There was a problem hiding this comment.
It is not fully new, the change is that we were doing it sequentially, while now we do it in parallel. It is the same change as for killing nodes. It will probably become more important as we scale
kevindeforth
previously approved these changes
Dec 16, 2025
Contributor
kevindeforth
left a comment
kevindeforth
left a comment
There was a problem hiding this comment.
Thanks, just nits (most of them regarding existing code)
…ts_premise_robust_ecdsa
kevindeforth
approved these changes
Dec 16, 2025
netrome
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves part 2 of #1640