chore: unify ckd and sign sandbox tests#1739
Merged
kevindeforth merged 7 commits intomainfrom Jan 13, 2026
Merged
Conversation
gilcu3
previously approved these changes
Jan 12, 2026
Contributor
gilcu3
left a comment
There was a problem hiding this comment.
Thank you, LGTM! Left a few comments/nits
gilcu3
previously approved these changes
Jan 12, 2026
Contributor
gilcu3
left a comment
There was a problem hiding this comment.
Thank you! Left a nit/fix
Co-authored-by: Reynaldo Gil Pons <gilcu3@gmail.com>
gilcu3
previously approved these changes
Jan 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR successfully unifies the CKD and Sign sandbox tests by:
- Deleting the redundant
sandbox/ckd.rsfile - Extending
sign.rsto test all signature schemes including BLS12381 (CKD domain) - Creating a
DomainResponseTestenum to handle both Sign and CKD test types - Refactoring helper functions to work with all domain types
- Moving common utilities to appropriate locations
Changes:
- Introduced
DomainResponseTestenum to unify Sign and CKD test handling - Updated all sign tests to iterate over all signature schemes instead of just non-CKD schemes
- Refactored test generation to use randomized inputs instead of hardcoded values
- Moved
create_account_given_idhelper function fromckd.rstocommon.rsfor shared use
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
crates/contract/tests/sandbox/mod.rs |
Removed the ckd module declaration |
crates/contract/tests/sandbox/ckd.rs |
Deleted entire file (374 lines) - tests migrated to sign.rs |
crates/contract/tests/sandbox/sign.rs |
Updated tests to cover all signature schemes; split single test into multiple focused tests; added CKD domain testing |
crates/contract/tests/sandbox/common.rs |
Added create_account_given_id helper function moved from deleted ckd.rs |
crates/contract/tests/sandbox/utils/sign_utils.rs |
Major refactoring: added DomainResponseTest enum, CKDRequestTest struct, trait ContractQueueRequest; made several functions private; removed unused imports |
crates/contract/tests/sandbox/upgrade_to_current_contract.rs |
Updated to use new CKDResponseArgs wrapper structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@kevindeforth Sorry, I got caught up fixing my PRs. I’ll review it early tomorrow morning. |
018c0ed to
8d75918
Compare
8d75918 to
df27d57
Compare
pbeza
previously approved these changes
Jan 13, 2026
gilcu3
approved these changes
Jan 13, 2026
pbeza
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1684