chore: make pprof web server endpoint queriable#1816
Merged
Conversation
gilcu3
approved these changes
Jan 21, 2026
Contributor
gilcu3
left a comment
gilcu3
left a comment
There was a problem hiding this comment.
Thank you!
Just to make sure I understand the changes, the pytest part is just adding a missing test there? I don't really see the relation with the change in the node
Contributor
Author
Correct, it's testing an existing endpoint. But it's also sanity checking that the query parameters work. This test would have failed before the change to the web server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1815