Conversation
gilcu3
force-pushed
the
1150-fix-and-re-enable-broken-contract-tee-tests
branch
from
4a72682 to
7283efb
Compare
| attestation: &Attestation, | ||
| tls_key: &Ed25519PublicKey, | ||
| ) -> anyhow::Result<bool> { | ||
| ) -> anyhow::Result<ExecutionFinalResult> { |
There was a problem hiding this comment.
this change is not strictly needed anymore, but seems like a good practice so that the function can also be used to match specific errors in case of failure
Cargo.toml
Outdated
| "serde", | ||
| ], default-features = false } | ||
| dcap-qvl = { version = "0.3.10", default-features = false, features = ["contract", "borsh", "std"] } | ||
| dcap-qvl = { version = "0.3.10", default-features = false, features = ["contract", "borsh", "std", "ring"] } |
There was a problem hiding this comment.
this is also not strictly needed to solve the issue, as we now use unit tests. But still without this attestations would fail, see Phala-Network/dcap-qvl#99
There was a problem hiding this comment.
The ring feature is supported since v0.3.11. You may need to update the dcap-qvl version.
There was a problem hiding this comment.
oh, that was the point so this was probably a typo on my side
EDIT: indeed Cargo.lock had been updated, else it shouldn't have worked 😄
barakeinav1
left a comment
barakeinav1
left a comment
There was a problem hiding this comment.
looks good. thanks.
one tiny comment
DSharifi
left a comment
DSharifi
left a comment
There was a problem hiding this comment.
Thanks for enabling these tests!
I have some small nits, but otherwise looks very good 💯
4 participants
Closes #1150