Skip to content

fix(network): TCP Listener task must not die#1983

Merged
kevindeforth merged 4 commits intomainfrom
kd/1979-network-fix
Feb 5, 2026
Merged

fix(network): TCP Listener task must not die#1983
kevindeforth merged 4 commits intomainfrom
kd/1979-network-fix

Conversation

@kevindeforth
Copy link
Contributor

@kevindeforth kevindeforth commented Feb 5, 2026

resolves #1979

follow-up issue for test: #1984

netrome
netrome previously approved these changes Feb 5, 2026
Copy link
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit noisy to review since we both alter the behavior and break out the incoming connection handler into a separate function. I feel like this PR could be simplified to a ~5 line change focusing on the new behavior by just changing the inner while loop to an infinite loop with a let Ok(...) = ... else {<handle error and continue>}

@kevindeforth kevindeforth marked this pull request as ready for review February 5, 2026 09:05
netrome
netrome previously approved these changes Feb 5, 2026
@kevindeforth kevindeforth added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 343c65f Feb 5, 2026
8 checks passed
@kevindeforth kevindeforth deleted the kd/1979-network-fix branch February 5, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCP Listener task can silently die

3 participants