Skip to content

test: check if 100s is enough to avoid flaky tests#1993

Merged
gilcu3 merged 1 commit intomainfrom
gilcu3/follow_up_1945
Feb 6, 2026
Merged

test: check if 100s is enough to avoid flaky tests#1993
gilcu3 merged 1 commit intomainfrom
gilcu3/follow_up_1945

Conversation

@gilcu3
Copy link
Contributor

@gilcu3 gilcu3 commented Feb 5, 2026

This is a follow up to #1945 which seems to have introduced its own flaky test issue

@DSharifi DSharifi changed the title fix: check if 100s is enough to avoid flaky tests test: check if 100s is enough to avoid flaky tests Feb 5, 2026
@gilcu3 gilcu3 enabled auto-merge February 5, 2026 16:25
@gilcu3 gilcu3 added this pull request to the merge queue Feb 6, 2026
@gilcu3 gilcu3 removed this pull request from the merge queue due to a manual request Feb 6, 2026
@gilcu3 gilcu3 added this pull request to the merge queue Feb 6, 2026
@gilcu3 gilcu3 removed this pull request from the merge queue due to a manual request Feb 6, 2026
@gilcu3 gilcu3 added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@gilcu3
Copy link
Contributor Author

gilcu3 commented Feb 6, 2026

@DSharifi it already happened. Even with a timeout of 100s, it failed https://github.com/near/mpc/actions/runs/21748901746/job/62741598753 in one of the tests creating lots of accounts. Wdyt about pivoting to the retry mechanism as originally proposed?

@gilcu3 gilcu3 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 76e81f3 Feb 6, 2026
15 of 16 checks passed
@gilcu3 gilcu3 deleted the gilcu3/follow_up_1945 branch February 6, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants