feat: implement verify foreign key logic in the contract#2008
Merged
Conversation
gilcu3
force-pushed
the
1965-implement-verify-foreign-tx-function-in-the-contract
branch
from
a9844e4 to
2f0f0ef
Compare
netrome
previously approved these changes
Feb 7, 2026
Collaborator
netrome
left a comment
netrome
left a comment
There was a problem hiding this comment.
Nice stuff. Just a testing opinion, pushing for the new convention. I'd find it much easier to read in this case, because the current test name doesn't really say anything and readers are therefore forced to read the code to understand what the test is supposed to test. I know this mirrors existing code so not a blocker ofc.
gilcu3
force-pushed
the
1965-implement-verify-foreign-tx-function-in-the-contract
branch
from
2f0f0ef to
8711640
Compare
netrome
approved these changes
Feb 9, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gilcu3
deleted the
1965-implement-verify-foreign-tx-function-in-the-contract
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1965