Merged
Conversation
DSharifi
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1932
The cluprit seems to have been a mix of
jemallocand thebuiltcrate. The jemalloc part was fixed in #1935. Would be nice to add it backI got repro with this branch, locally:
and in CI https://github.com/near/mpc/actions/runs/21820809884/job/62953357578
added also a nit, as we are using/testing claude locally we should ignore the local config folder
This is the TL;DR of the fix:
The built crate generates ~20 constants via include!(), and we only use 4 of them. The unused ones still end up in the binary (they were pub const in a pub mod), and some would differ between local and CI (why this was not happening before is a mystery, but hopefully now we are more robust):
These unused but still-present constants apparently shifted the positions of stuff in .rodata., obtained with: