chore: upgrade and organize workspace deps#2052
Conversation
gilcu3
force-pushed
the
2050-upgrade-and-organized-workspace-dependencies
branch
2 times, most recently
from
37b6863 to
d727c59
Compare
|
|
||
| [bans] | ||
| multiple-versions = "deny" | ||
| multiple-versions = "warn" |
There was a problem hiding this comment.
as discussed recently in slack, failing for duplicates is not a good choice, so a warning is fine here
gilcu3
force-pushed
the
2050-upgrade-and-organized-workspace-dependencies
branch
from
d727c59 to
ea0cb6c
Compare
|
|
||
| ## Outdated dependencies we cannot upgrade ## | ||
| # Version 0.8.3 requires rustc 1.88 | ||
| httpmock = "0.8.2" |
There was a problem hiding this comment.
| httpmock = "0.8.2" | |
| httpmock = "=0.8.2" |
There was a problem hiding this comment.
Suggesting on your own PR? 😂
There was a problem hiding this comment.
yeah didn't want to do a git switch locally and break reviewers view :)
There was a problem hiding this comment.
Now that we have the new resolver, we don't need to pin versions because of MSRV
There was a problem hiding this comment.
True, that's really nice :) although it only helps when doing the bumping automatically, so the = will still give the correct sign to the manual updater
DSharifi
left a comment
DSharifi
left a comment
There was a problem hiding this comment.
Thanks for doing this.
Some of the comments and pinning of versions are inaccurate though.
gilcu3
force-pushed
the
2050-upgrade-and-organized-workspace-dependencies
branch
2 times, most recently
from
ea5014f to
cef22ac
Compare
gilcu3
force-pushed
the
2050-upgrade-and-organized-workspace-dependencies
branch
from
228d272 to
054745e
Compare
|
@claude can you review? |
3 participants
Closes #2050